Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1464263003: Add metro driver and delegate_execute to GN build. (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metro driver and delegate_execute to GN build. This also makes //win8/* pass "gn check". BUG=512864, 512869 Committed: https://crrev.com/0ead977816dc8163cbda64214b2ba8cc779fab85 Cr-Commit-Position: refs/heads/master@{#361211}

Patch Set 1 #

Patch Set 2 : delegate execute #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -23 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/metro_viewer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/metro_viewer/metro_viewer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M win8/BUILD.gn View 4 chunks +26 lines, -20 lines 0 comments Download
A win8/delegate_execute/BUILD.gn View 1 1 chunk +79 lines, -0 lines 0 comments Download
M win8/delegate_execute/chrome_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 3 chunks +3 lines, -0 lines 0 comments Download
A win8/metro_driver/BUILD.gn View 1 1 chunk +128 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/BUILD.gn View 1 1 chunk +29 lines, -0 lines 0 comments Download
M win8/metro_driver/ime/ime.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
5 years, 1 month ago (2015-11-23 19:16:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464263003/20001
5 years, 1 month ago (2015-11-23 19:17:01 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464263003/40001
5 years, 1 month ago (2015-11-23 19:22:58 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 20:18:56 UTC) #10
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-23 22:51:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464263003/40001
5 years, 1 month ago (2015-11-23 22:55:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-23 23:12:19 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:13:00 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0ead977816dc8163cbda64214b2ba8cc779fab85
Cr-Commit-Position: refs/heads/master@{#361211}

Powered by Google App Engine
This is Rietveld 408576698