Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1464253002: Fix non-<number> calcs being accepted as numbers (Closed)

Created:
5 years, 1 month ago by Timothy Loh
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, cbiesinger, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-<number> calcs being accepted as numbers This patch fixes a missing check in CalcParser::consumeNumberRaw for the CalcNumber category. This was causing non-<number> calcs to be accepted as numbers (which caused problems in flex where <number> and <length> can be used in the same shorthand, e.g. flex: calc(10px + 50%) 1 2) BUG=559513, 499780 Committed: https://crrev.com/42ee07bfde71224b71dd8cbe5f5bd02aa87e9d35 Cr-Commit-Position: refs/heads/master@{#361070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/flex-property-parsing.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flex-property-parsing-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
5 years, 1 month ago (2015-11-23 05:27:31 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 1 month ago (2015-11-23 05:34:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464253002/1
5 years, 1 month ago (2015-11-23 05:35:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 06:36:07 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 06:36:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42ee07bfde71224b71dd8cbe5f5bd02aa87e9d35
Cr-Commit-Position: refs/heads/master@{#361070}

Powered by Google App Engine
This is Rietveld 408576698