Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 146423002: Move [StrictTypeChecking] to interface (from members), where possible (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, fs, eric.carlson_apple.com, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, dino_apple.com, rwlbuis, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), dstockwell, Timothy Loh, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, Eric Willigers, nessy, rjwright, sof, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, krit, gyuyoung.kim_webkit.org, darktears, kojih, vcarbune.chromium, philipj_slow, jsbell+bindings_chromium.org, gasubic, Mike Lawther (Google), ed+blinkwatch_opera.com, Steve Block, f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com, kouhei (in TOK)
Visibility:
Public.

Description

Move [StrictTypeChecking] to interface (from members), where possible No changes to generated bindings: just simplification. kouhei: there's one case in an SVG IDL that might need fixing, namely createSVGTransformFromMatrix in Source/core/svg/SVGSVGElement.idl (only case of an SVG method not having [StrictTypeChecking] when others on the interface do) [StrictTypeChecking] is almost always applied to all members of an interface. Thus it's clearer and safer to put in on the interface, instead of the members. This requires minimal CG changes (just check [StrictTypeChecking] on interface), and allows *massive* simplification of IDL files. This is ultimately in support of the SVG bindings rewrite, as we want strict type checking there for null. There are only 3 IDL files left with [StrictTypeChecking] on members: (outside of test cases) * Source/core/html/HTMLMediaElement.idl * Source/core/svg/SVGSVGElement.idl :: kouhei? * Source/modules/mediastream/RTCPeerConnection.idl Also some formatting fixes to WebGLRenderingContext.idl, which is v. long and was quite inconsistent. (And a few to SVGPathElement.idl, due to long argument lists.) Followup to: Add null-correctness checking to [StrictTypeChecking] methods https://codereview.chromium.org/141523002/ BUG=249598 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165749

Patch Set 1 #

Patch Set 2 : Tweak #

Patch Set 3 : Rebased (merge) #

Patch Set 4 : Fix comma #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -449 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_attributes.py View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +3 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterfacePython.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 6 chunks +46 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/html/canvas/DataView.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.idl View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.idl View 2 chunks +194 lines, -182 lines 0 comments Download
M Source/core/svg/SVGAngle.idl View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGLength.idl View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGLengthList.idl View 1 chunk +8 lines, -7 lines 0 comments Download
M Source/core/svg/SVGMatrix.idl View 1 chunk +16 lines, -15 lines 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGNumberList.idl View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +33 lines, -27 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 chunk +10 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 chunk +10 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 chunk +7 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegList.idl View 1 chunk +9 lines, -8 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPointList.idl View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.idl View 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/svg/SVGRect.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStringList.idl View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGTransform.idl View 2 chunks +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGTransformList.idl View 1 chunk +10 lines, -8 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
6 years, 11 months ago (2014-01-24 06:30:32 UTC) #1
Nils Barth (inactive)
+philipj
6 years, 11 months ago (2014-01-24 06:32:35 UTC) #2
haraken
rubberstamp LGTM.
6 years, 11 months ago (2014-01-24 06:33:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/146423002/80001
6 years, 11 months ago (2014-01-24 07:03:31 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGNumber.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-24 08:14:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/146423002/190001
6 years, 11 months ago (2014-01-24 10:21:06 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 13:54:45 UTC) #7
Message was sent while issue was closed.
Change committed as 165749

Powered by Google App Engine
This is Rietveld 408576698