|
Move [StrictTypeChecking] to interface (from members), where possible
No changes to generated bindings: just simplification.
kouhei:
there's one case in an SVG IDL that might need fixing,
namely createSVGTransformFromMatrix in
Source/core/svg/SVGSVGElement.idl
(only case of an SVG method not having [StrictTypeChecking]
when others on the interface do)
[StrictTypeChecking] is almost always applied to all members of an interface.
Thus it's clearer and safer to put in on the interface, instead of the members.
This requires minimal CG changes (just check [StrictTypeChecking] on interface),
and allows *massive* simplification of IDL files.
This is ultimately in support of the SVG bindings rewrite,
as we want strict type checking there for null.
There are only 3 IDL files left with [StrictTypeChecking] on members:
(outside of test cases)
* Source/core/html/HTMLMediaElement.idl
* Source/core/svg/SVGSVGElement.idl :: kouhei?
* Source/modules/mediastream/RTCPeerConnection.idl
Also some formatting fixes to WebGLRenderingContext.idl,
which is v. long and was quite inconsistent.
(And a few to SVGPathElement.idl, due to long argument lists.)
Followup to:
Add null-correctness checking to [StrictTypeChecking] methods
https://codereview.chromium.org/141523002/
BUG= 249598
R=haraken
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165749
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+563 lines, -449 lines) |
Patch |
 |
M |
Source/bindings/scripts/code_generator_v8.pm
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/scripts/unstable/v8_attributes.py
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/scripts/unstable/v8_methods.py
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/idls/TestInterfacePython.idl
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython.cpp
|
View
|
|
6 chunks |
+46 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLMediaElement.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/ANGLEInstancedArrays.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/DataView.idl
|
View
|
|
1 chunk |
+13 lines, -13 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/OESVertexArrayObject.idl
|
View
|
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/WebGLDebugShaders.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/WebGLLoseContext.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/WebGLRenderingContext.idl
|
View
|
|
2 chunks |
+194 lines, -182 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGAngle.idl
|
View
|
|
2 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGAnimatedBoolean.idl
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGAnimatedEnumeration.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGAnimatedInteger.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGAnimatedNumber.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGFitToViewBox.idl
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGLength.idl
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGLengthList.idl
|
View
|
|
1 chunk |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGMatrix.idl
|
View
|
|
1 chunk |
+16 lines, -15 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGNumber.idl
|
View
|
1
2
3
4
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGNumberList.idl
|
View
|
1
2
3
4
|
1 chunk |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathElement.idl
|
View
|
|
1 chunk |
+33 lines, -27 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegArcAbs.idl
|
View
|
|
1 chunk |
+10 lines, -9 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegArcRel.idl
|
View
|
|
1 chunk |
+10 lines, -9 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoCubicAbs.idl
|
View
|
|
1 chunk |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoCubicRel.idl
|
View
|
|
1 chunk |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl
|
View
|
|
1 chunk |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoAbs.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoHorizontalRel.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoRel.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoVerticalAbs.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegLinetoVerticalRel.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegList.idl
|
View
|
|
1 chunk |
+9 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegMovetoAbs.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPathSegMovetoRel.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPoint.idl
|
View
|
1
2
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPointList.idl
|
View
|
1
2
3
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGPreserveAspectRatio.idl
|
View
|
|
2 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGRect.idl
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGSVGElement.idl
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGStringList.idl
|
View
|
|
1 chunk |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGTransform.idl
|
View
|
|
2 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGTransformList.idl
|
View
|
|
1 chunk |
+10 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/svg/SVGZoomAndPan.idl
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediastream/RTCPeerConnection.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/webaudio/AudioBufferSourceNode.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
Total messages: 7 (0 generated)
|