Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 14642024: [NaCl SDK] nacl_io: Fix dlopen'ing a file not in the .nmf (Closed)

Created:
7 years, 7 months ago by binji
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix dlopen'ing a file not in the .nmf The dlopen example demonstrates opening a .so file that is not located in the manifest; for example, from a HTTP mount. The nacl_io code was broken as a result of a recent change to "fast path" nexe loading/validation in certain cases. This change attempts to mmap the nexe using PROT_EXEC, which we would ignore and happily write to a bad address. Now, we always fail PROT_EXEC requests, which should fallback gracefully to the old way. BUG=none R=sbc@chromium.org R=ncbray@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M native_client_sdk/src/libraries/nacl_io/mount_node.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
7 years, 7 months ago (2013-05-06 23:42:30 UTC) #1
Sam Clegg
lgtm
7 years, 7 months ago (2013-05-07 00:25:56 UTC) #2
binji
7 years, 7 months ago (2013-05-07 20:39:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r198791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698