Allow pnacl-freeze/thaw to redirect to stdin/stdout.

Allow pnacl-freeze/thaw to redirect to stdin/stdout.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3405
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=e8e0569

[Karl, 2013-05-02 21:49:05]

PTAL. Thanks.

[jvoung (off chromium), 2013-05-02 22:12:50]

https://codereview.chromium.org/14642019/diff/1/tools/pnacl-freeze/pnacl-free...
File tools/pnacl-freeze/pnacl-freeze.cpp (right):

https://codereview.chromium.org/14642019/diff/1/tools/pnacl-freeze/pnacl-free...
tools/pnacl-freeze/pnacl-freeze.cpp:45: input_filename = "<stdin>";
What some of the other tools do is set OutputFilename to be "-" also, in the
case Input is "-" and Output is not specified.  That might be simpler than this,
since this would leave a file with funny characters "<stdin>.frozen" in its
name?

[Karl, 2013-05-06 16:21:51]

https://codereview.chromium.org/14642019/diff/1/tools/pnacl-freeze/pnacl-free...
File tools/pnacl-freeze/pnacl-freeze.cpp (right):

https://codereview.chromium.org/14642019/diff/1/tools/pnacl-freeze/pnacl-free...
tools/pnacl-freeze/pnacl-freeze.cpp:45: input_filename = "<stdin>";
On 2013/05/02 22:12:50, jvoung (cr) wrote:
> What some of the other tools do is set OutputFilename to be "-" also, in the
> case Input is "-" and Output is not specified.  That might be simpler than
this,
> since this would leave a file with funny characters "<stdin>.frozen" in its
> name?

I guess this is ok. I just have to redirect my mind to think in terms of pipes.
Changing.

[jvoung (off chromium), 2013-05-06 18:48:54]

LGTM (some tabs though?)

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-freeze/pnacl-f...
File tools/pnacl-freeze/pnacl-freeze.cpp (right):

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-freeze/pnacl-f...
tools/pnacl-freeze/pnacl-freeze.cpp:34: cl::value_desc("filename"),
cl::init("-"));
tab?

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-thaw/pnacl-tha...
File tools/pnacl-thaw/pnacl-thaw.cpp (right):

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-thaw/pnacl-tha...
tools/pnacl-thaw/pnacl-thaw.cpp:33: cl::value_desc("filename"), cl::init("-"));
tab?

[Karl, 2013-05-06 20:03:55]

Committed patchset #4 manually as re8e0569 (presubmit successful).

[Karl, 2013-05-06 20:13:06]

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-freeze/pnacl-f...
File tools/pnacl-freeze/pnacl-freeze.cpp (right):

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-freeze/pnacl-f...
tools/pnacl-freeze/pnacl-freeze.cpp:34: cl::value_desc("filename"),
cl::init("-"));
On 2013/05/06 18:48:54, jvoung (cr) wrote:
> tab?

Done.

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-thaw/pnacl-tha...
File tools/pnacl-thaw/pnacl-thaw.cpp (right):

https://codereview.chromium.org/14642019/diff/6003/tools/pnacl-thaw/pnacl-tha...
tools/pnacl-thaw/pnacl-thaw.cpp:33: cl::value_desc("filename"), cl::init("-"));
On 2013/05/06 18:48:54, jvoung (cr) wrote:
> tab?

Done.