Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 14642002: Two bugfixes for hydrogen-based array constructors (Closed)

Created:
7 years, 7 months ago by mvstanton
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Two bugfixes for hydrogen-based array constructors CacheInitialJSArrayMaps needs to be able to pick up where it left off, as it can now be called from a handlfied context. Disable incremental marking for CCTest SetJitCodeEventHandler, as it allocates during compilation. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14495

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Here is the change we discussed. The cctest change, disabling incremental marking was discussed with ...
7 years, 7 months ago (2013-04-30 11:10:42 UTC) #1
Toon Verwaest
lgtm
7 years, 7 months ago (2013-04-30 11:50:58 UTC) #2
mvstanton
7 years, 7 months ago (2013-04-30 13:43:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698