media/mp4/box_definitions.cc - Issue 14641006: Support EAC3 (Dolby Digital Plus) codec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/box_definitions.cc

Issue 14641006: Support EAC3 (Dolby Digital Plus) codec (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Aaron's comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/box_definitions.cc

diff --git a/media/mp4/box_definitions.cc b/media/mp4/box_definitions.cc

index 6c645be4acd2109b52fe1321df25a498e87e50cf..e7f169323bb6b90a94854d9bfe9ce55bc07bcd3e 100644

--- a/media/mp4/box_definitions.cc

+++ b/media/mp4/box_definitions.cc

@@ -467,7 +467,8 @@ bool AudioSampleEntry::Parse(BoxReader* reader) {

}

- RCHECK(reader->ReadChild(&esds));

+ // ESDS is not valid in case of EAC3.

+ RCHECK(reader->MaybeReadChild(&esds));

return true;

}