Upstream IOSChromeIOThread to hold data primarily used on IO thread.

Upstream IOSChromeIOThread to hold data primarily used on IO thread.

IOSChromeIOThread initialises, holds and clean up data primarily used
on the IO thread. It is based on chrome/browser/io_thread.{cc,h} with
only the portion relevant to iOS kept.

BUG=556566
Committed: https://crrev.com/4b9b76c92cf7386d4983f536e75310a575515454
Cr-Commit-Position: refs/heads/master@{#361139}

[sdefresne, 2015-11-21 08:42:16]

sdefresne@chromium.org changed reviewers:
+ blundell@chromium.org, droger@chromium.org

[sdefresne, 2015-11-21 08:42:17]

Please take a look.

[sdefresne, 2015-11-21 08:49:01]

sdefresne@chromium.org changed reviewers:
+ davidben@chromium.org

[sdefresne, 2015-11-21 08:49:02]

davidben: can you review the new DEPS on components/ssl_config as OWNERS

[blundell, 2015-11-23 08:50:18]

Is it possible to get the cc file to show up as diff from io_thread.cc by
lowering --similarity?

[sdefresne, 2015-11-23 09:00:55]

On 2015/11/23 at 08:50:18, blundell wrote:
> Is it possible to get the cc file to show up as diff from io_thread.cc by
lowering --similarity?

Done. Please take another look.

[blundell, 2015-11-23 09:03:18]

LGTM

For anyone observing (now or later), feel free to reach out about the reasoning
behind the removal of any particular piece of code in this CL.

[sdefresne, 2015-11-23 17:18:48]

davidben: ping

[davidben, 2015-11-23 17:43:28]

DEPS lgtm.

(+mmenke FYI.)

https://codereview.chromium.org/1464083002/diff/20001/ios/chrome/browser/ios_...
File ios/chrome/browser/ios_chrome_io_thread.cc (right):

https://codereview.chromium.org/1464083002/diff/20001/ios/chrome/browser/ios_...
ios/chrome/browser/ios_chrome_io_thread.cc:90: const char
kSupportedAuthSchemes[] = "basic,digest,ntlm,negotiate";
I doubt Negotiate works on iOS. I believe it requires the system Kerberos
library. You probably want to double-check that you are shipping with it in the
list today. If it is, may be worth checking if you want to remove it in a
follow-up.

asanka@ would be a good person to talk to about how Negotiate works and what
including it in this list does (I'm not sure).

[sdefresne, 2015-11-23 17:48:18]

On 2015/11/23 at 17:43:28, davidben wrote:
> DEPS lgtm.
> 
> (+mmenke FYI.)
> 
>
https://codereview.chromium.org/1464083002/diff/20001/ios/chrome/browser/ios_...
> File ios/chrome/browser/ios_chrome_io_thread.cc (right):
> 
>
https://codereview.chromium.org/1464083002/diff/20001/ios/chrome/browser/ios_...
> ios/chrome/browser/ios_chrome_io_thread.cc:90: const char
kSupportedAuthSchemes[] = "basic,digest,ntlm,negotiate";
> I doubt Negotiate works on iOS. I believe it requires the system Kerberos
library. You probably want to double-check that you are shipping with it in the
list today. If it is, may be worth checking if you want to remove it in a
follow-up.

Double-checked and we do ship with it today. I'm pretty sure we do not link
against Kerberos library though. Filled
https://code.google.com/p/chromium/issues/detail?id=560411 to follow up on the
investigation.

> asanka@ would be a good person to talk to about how Negotiate works and what
including it in this list does (I'm not sure).

[sdefresne, 2015-11-23 17:48:36]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-11-23 17:49:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464083002/20001

[commit-bot: I haz the power, 2015-11-23 18:06:03]

Committed patchset #2 (id:20001)

[sdefresne, 2015-11-23 18:07:28]

On 2015/11/23 at 18:06:03, commit-bot wrote:
> Committed patchset #2 (id:20001)

\o/

[commit-bot: I haz the power, 2015-11-23 18:07:28]

Patchset 2 (id:??) landed as
https://crrev.com/4b9b76c92cf7386d4983f536e75310a575515454
Cr-Commit-Position: refs/heads/master@{#361139}