Issue 14640019: Regression issue with "ShouldHop"

Issue 14640019: Regression issue with "ShouldHop" (Closed)

Created:
7 years, 7 months ago by Harry McCleave

Modified:
7 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Regression issue with "ShouldHop", the UpdateState->Layout flow was updated during M-27 to resolve a similar issue due to Updates that didn't change bounds not flowing into Layout, however due to some merging/partial reverts, this flow got partially reverted regressing these bugs. BUG=234655 R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198585

Patch Set 1 #

Patch Set 2 : rm invalid unit test #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -14 lines)			Patch
	M	ash/launcher/launcher_button.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	ash/launcher/launcher_view_unittest.cc	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/14640019/1

7 years, 7 months ago (2013-05-03 23:34:09 UTC) #2

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=111035

7 years, 7 months ago (2013-05-04 02:26:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/14640019/21001

7 years, 7 months ago (2013-05-06 20:36:15 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=125784

7 years, 7 months ago (2013-05-07 00:15:54 UTC) #5

jennyz

7 years, 7 months ago (2013-05-07 01:12:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r198585 (presubmit successful).

Expand Messages | Collapse Messages