Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: tests/standalone/io/socket_invalid_arguments_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated comments with IPv6 info Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/socket_invalid_arguments_test.dart
diff --git a/tests/standalone/io/socket_invalid_arguments_test.dart b/tests/standalone/io/socket_invalid_arguments_test.dart
index 61d526db60924c0b00df2dff2f266aaec1759c4d..6cf09a2ab54d65ebb58c679ce96cb088a7ef0e61 100644
--- a/tests/standalone/io/socket_invalid_arguments_test.dart
+++ b/tests/standalone/io/socket_invalid_arguments_test.dart
@@ -25,7 +25,7 @@ testSocketCreation(host, port) {
}
testAdd(buffer) {
- ServerSocket.bind("127.0.0.1", 0, 5).then((server) {
+ ServerSocket.bind("127.0.0.1", 0, backlog: 5).then((server) {
Bill Hesse 2013/05/01 08:57:06 This is dropped everywhere else, why not here?
Søren Gjesse 2013/05/01 09:06:42 No particular reason, removed.
server.listen((socket) => socket.destroy());
Socket.connect("127.0.0.1", server.port).then((socket) {
int errors = 0;
@@ -49,7 +49,7 @@ testServerSocketCreation(address, port, backlog) {
var server;
var port = new ReceivePort();
try {
- ServerSocket.bind(address, port, backlog)
+ ServerSocket.bind(address, port, backlog: backlog)
.then((_) { Expect.fail("ServerSocket bound"); });
} catch (e) {
port.close();

Powered by Google App Engine
This is Rietveld 408576698