Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: tests/standalone/io/http_detach_socket_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_content_length_test.dart ('k') | tests/standalone/io/http_head_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_detach_socket_test.dart
diff --git a/tests/standalone/io/http_detach_socket_test.dart b/tests/standalone/io/http_detach_socket_test.dart
index 7d14b379d07a17b1045116acc56899ba04d5d1ae..2345079290793c01f80aba9f630d9e62b80e9ad2 100644
--- a/tests/standalone/io/http_detach_socket_test.dart
+++ b/tests/standalone/io/http_detach_socket_test.dart
@@ -12,7 +12,7 @@ import "dart:io";
import "dart:isolate";
void testServerDetachSocket() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((request) {
var response = request.response;
response.contentLength = 0;
@@ -48,7 +48,7 @@ void testServerDetachSocket() {
}
void testBadServerDetachSocket() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((request) {
var response = request.response;
response.contentLength = 0;
@@ -68,7 +68,7 @@ void testBadServerDetachSocket() {
}
void testClientDetachSocket() {
- ServerSocket.bind().then((server) {
+ ServerSocket.bind("127.0.0.1", 0).then((server) {
server.listen((socket) {
socket.write("HTTP/1.1 200 OK\r\n"
"\r\n"
« no previous file with comments | « tests/standalone/io/http_content_length_test.dart ('k') | tests/standalone/io/http_head_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698