Issue 1463973002: Mising JS refactoring in XFA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1463973002: Mising JS refactoring in XFA. (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Define.h	View	7 chunks	+13 lines, -14 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	2 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, for review. No functional changes, just moves one repeated call into another function (should ...

5 years, 1 month ago (2015-11-20 21:46:13 UTC) #2

Tom Sepez

5 years, 1 month ago (2015-11-20 22:23:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8ec0a3405c6f184e4b9811870081295cae078c9 (presubmit successful).