Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 1463923002: fix pathops coincidence fuzz bug (Closed)

Created:
5 years, 1 month ago by caryclark
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix pathops coincidence fuzz bug Simplifying a series of rects with very large bounds triggers a coincidence bug where, after one of the intersection points that marks a coincident range has been deleted, it is referenced. Both the deletion and reference is (probably) happening in the SkOpCoincidence::AddExpanded() phase of HandleCoincidence(), and may signify a bug that could happen with usable input data, but I haven't been able to determine that. For now, abort the Simplify() when the erroneous condition is detected. TBR=reed@google.com BUG=558281 Committed: https://skia.googlesource.com/skia/+/1c9ce610501b7b864617356aeda12cd0caebe066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463923002/1
5 years, 1 month ago (2015-11-20 21:19:16 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 22:06:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c9ce610501b7b864617356aeda12cd0caebe066

Powered by Google App Engine
This is Rietveld 408576698