third_party/WebKit/Source/core/layout/BidiRunForLine.cpp - Issue 1463893002: Ignore unicode-bidi: isolate for visual order elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

Issue 1463893002: Ignore unicode-bidi: isolate for visual order elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed to treatAsIsolated() Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/text/international/iso-8859-8-and-isolate-expected.html ('k') | third_party/WebKit/Source/core/layout/line/InlineIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

index 8ade9f83e1e5b644137cd5acf5b6874d37fa978e..a3317ce0de3efa22af413220f708c99022fe63be 100644

--- a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

+++ b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

@@ -35,7 +35,7 @@ static LayoutObject* firstLayoutObjectForDirectionalityDetermination(

{

LayoutObject* next = current;

while (current) {

- if (isIsolated(current->style()->unicodeBidi())

+ if (treatAsIsolated(current->styleRef())

&& (current->isLayoutInline() || current->isLayoutBlock())) {

if (current != root)

current = nullptr;

@@ -56,7 +56,7 @@ static LayoutObject* firstLayoutObjectForDirectionalityDetermination(

break;

if (!isIteratorTarget(LineLayoutItem(current))

- && !isIsolated(current->style()->unicodeBidi()))

+ && !treatAsIsolated(current->styleRef()))

next = current->slowFirstChild();

if (!next) {