Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1463853002: Mac: Move IOSurface token initialization earlier (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Move IOSurface token initialization earlier Move from RenderProcessHostImpl::OnChannelEstablished to RenderProcessHostImpl::OnProcessLaunched, so that it comes in before the first burst of IPCs to the renderer. Change token DCHECKs to CHECKs, because they will crash the renderer later on. BUG=554541 Committed: https://crrev.com/51fdb858aee9e3fe69eb84260f7d607dcbc44e1f Cr-Commit-Position: refs/heads/master@{#361099}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M content/child/child_io_surface_manager_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
reveman
lgtm
5 years, 1 month ago (2015-11-20 20:26:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463853002/1
5 years, 1 month ago (2015-11-20 20:28:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/126178) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 20:31:09 UTC) #6
ccameron
Adding avi@ for content/ stamp.
5 years, 1 month ago (2015-11-22 02:16:02 UTC) #8
Avi (use Gerrit)
lgtm stamp
5 years, 1 month ago (2015-11-22 15:33:04 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1458703010 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-22 21:26:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463853002/40001
5 years, 1 month ago (2015-11-23 13:29:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/139823) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-23 13:30:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463853002/60001
5 years, 1 month ago (2015-11-23 13:46:31 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 14:52:34 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 14:53:22 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/51fdb858aee9e3fe69eb84260f7d607dcbc44e1f
Cr-Commit-Position: refs/heads/master@{#361099}

Powered by Google App Engine
This is Rietveld 408576698