Issue 1463833003: Don't update incrementally invalid results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1463833003: Don't update incrementally invalid results. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't update incrementally invalid results. Invalid results don't have correct dependencies, so if we make them valid, they will never get invalidated later. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0f477023a4b0af017d20db8ad67ba602920829ed

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/context/cache.dart	View		1 chunk	+6 lines, -4 lines	1 comment	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		5 chunks	+46 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1463833003/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/1463833003/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode519 pkg/analyzer/lib/src/context/cache.dart:519: if (data.state == CacheState.VALID) { I think we ...

5 years, 1 month ago (2015-11-20 19:47:47 UTC) #2

scheglov

5 years, 1 month ago (2015-11-20 20:29:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f477023a4b0af017d20db8ad67ba602920829ed (presubmit successful).

Expand Messages | Collapse Messages