Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463833002: [iOS] Unfork ChromeBrowserStateManager (Closed)

Created:
5 years, 1 month ago by droger
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Unfork ChromeBrowserStateManager This CL renames the methods so that they are consistently using "BrowserState" instead of a mix of "BrowserState" and "ChromeBrowserState". Committed: https://crrev.com/f00421f451da31dd5c04031d0505243d0c11ba48 Cr-Commit-Position: refs/heads/master@{#361080}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M ios/chrome/browser/application_context_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/ios_chrome_signin_status_metrics_provider_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/glue/sync_start_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/browser_state/chrome_browser_state_manager.h View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
droger
5 years, 1 month ago (2015-11-20 16:21:54 UTC) #2
blundell
lgtm
5 years, 1 month ago (2015-11-23 08:30:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463833002/20001
5 years, 1 month ago (2015-11-23 08:56:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 09:08:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 09:09:38 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f00421f451da31dd5c04031d0505243d0c11ba48
Cr-Commit-Position: refs/heads/master@{#361080}

Powered by Google App Engine
This is Rietveld 408576698