third_party/WebKit/Source/web/PageWidgetDelegate.h - Issue 1463823003: Return a enumeration of the state of handling of InputEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageWidgetDelegate.h

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build failures and disabled click test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | third_party/WebKit/Source/web/PageWidgetDelegate.cpp » ('j') | third_party/WebKit/public/platform/WebInputEventResult.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/PageWidgetDelegate.h

diff --git a/third_party/WebKit/Source/web/PageWidgetDelegate.h b/third_party/WebKit/Source/web/PageWidgetDelegate.h

index cb0a288ff2cfb8a20561b2ae1d140db2aebcff42..31403630ad38385854e92a742067b3b4690cc6d2 100644

--- a/third_party/WebKit/Source/web/PageWidgetDelegate.h

+++ b/third_party/WebKit/Source/web/PageWidgetDelegate.h

@@ -53,11 +53,11 @@ public:

virtual void handleMouseLeave(LocalFrame& mainFrame, const WebMouseEvent&);

virtual void handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent&);

virtual void handleMouseUp(LocalFrame& mainFrame, const WebMouseEvent&);

- virtual bool handleMouseWheel(LocalFrame& mainFrame, const WebMouseWheelEvent&);

- virtual bool handleKeyEvent(const WebKeyboardEvent&) = 0;

- virtual bool handleCharEvent(const WebKeyboardEvent&) = 0;

- virtual bool handleGestureEvent(const WebGestureEvent&) = 0;

- virtual bool handleTouchEvent(LocalFrame& mainFrame, const WebTouchEvent&);

+ virtual WebInputEventResult handleMouseWheel(LocalFrame& mainFrame, const WebMouseWheelEvent&);

+ virtual WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) = 0;

+ virtual WebInputEventResult handleCharEvent(const WebKeyboardEvent&) = 0;

+ virtual WebInputEventResult handleGestureEvent(const WebGestureEvent&) = 0;

+ virtual WebInputEventResult handleTouchEvent(LocalFrame& mainFrame, const WebTouchEvent&);

virtual ~PageWidgetEventHandler() { }

protected:

const char* inputTypeToName(WebInputEvent::Type);

@@ -80,7 +80,7 @@ public:

static void paintIgnoringCompositing(Page&, WebCanvas*, const WebRect&, LocalFrame& root);

// See FIXME in the function body about nullptr |root|.

- static bool handleInputEvent(PageWidgetEventHandler&, const WebInputEvent&, LocalFrame* root);

+ static WebInputEventResult handleInputEvent(PageWidgetEventHandler&, const WebInputEvent&, LocalFrame* root);

private:

PageWidgetDelegate() { }