Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.h
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.h b/third_party/WebKit/Source/web/WebPagePopupImpl.h
index 27174da6826e640d5750b9cad57ec8a941a8b26c..07886cd2980614f7d9f237978072022b0d50c7e9 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.h
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.h
@@ -60,7 +60,7 @@ class WebPagePopupImpl final
public:
~WebPagePopupImpl() override;
bool initialize(WebViewImpl*, PagePopupClient*);
- bool handleKeyEvent(const PlatformKeyboardEvent&);
+ WebInputEventResult handleKeyEvent(const PlatformKeyboardEvent&);
void closePopup();
WebWidgetClient* widgetClient() const { return m_widgetClient; }
bool hasSamePopupClient(WebPagePopupImpl* other) { return other && m_popupClient == other->m_popupClient; }
@@ -79,17 +79,17 @@ private:
void paint(WebCanvas*, const WebRect&) override;
void resize(const WebSize&) override;
void close() override;
- bool handleInputEvent(const WebInputEvent&) override;
+ WebInputEventResult handleInputEvent(const WebInputEvent&) override;
void setFocus(bool) override;
bool isPagePopup() const override { return true; }
bool isAcceleratedCompositingActive() const override { return m_isAcceleratedCompositingActive; }
// PageWidgetEventHandler functions
- bool handleKeyEvent(const WebKeyboardEvent&) override;
- bool handleCharEvent(const WebKeyboardEvent&) override;
- bool handleGestureEvent(const WebGestureEvent&) override;
+ WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
+ WebInputEventResult handleCharEvent(const WebKeyboardEvent&) override;
+ WebInputEventResult handleGestureEvent(const WebGestureEvent&) override;
void handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent&) override;
- bool handleMouseWheel(LocalFrame& mainFrame, const WebMouseWheelEvent&) override;
+ WebInputEventResult handleMouseWheel(LocalFrame& mainFrame, const WebMouseWheelEvent&) override;
bool isMouseEventInWindow(const WebMouseEvent&);
bool isGestureEventInWindow(const WebGestureEvent&);

Powered by Google App Engine
This is Rietveld 408576698