Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.h
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
index cf573f272a72ccb9af79d16c38c0186f1e471d3a..5184b50813c252a85869c390d1774071904c97ec 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
@@ -83,7 +83,7 @@ public:
void layoutAndPaintAsync(WebLayoutAndPaintAsyncCallback*) override;
void compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCallback*) override;
void themeChanged() override;
- bool handleInputEvent(const WebInputEvent&) override;
+ WebInputEventResult handleInputEvent(const WebInputEvent&) override;
void setCursorVisibilityState(bool isVisible) override;
bool hasTouchEventHandlersAt(const WebPoint&) override;
@@ -170,10 +170,10 @@ private:
HitTestResult hitTestResultForRootFramePos(const IntPoint& posInRootFrame);
// Returns true if the event was actually processed.
- bool keyEventDefault(const WebKeyboardEvent&);
+ WebInputEventResult keyEventDefault(const WebKeyboardEvent&);
// Returns true if the view was scrolled.
- bool scrollViewWithKeyboard(int keyCode, int modifiers);
+ WebInputEventResult scrollViewWithKeyboard(int keyCode, int modifiers);
void initializeLayerTreeView();
@@ -188,10 +188,10 @@ private:
void handleMouseLeave(LocalFrame&, const WebMouseEvent&) override;
void handleMouseDown(LocalFrame&, const WebMouseEvent&) override;
void handleMouseUp(LocalFrame&, const WebMouseEvent&) override;
- bool handleMouseWheel(LocalFrame&, const WebMouseWheelEvent&) override;
- bool handleGestureEvent(const WebGestureEvent&) override;
- bool handleKeyEvent(const WebKeyboardEvent&) override;
- bool handleCharEvent(const WebKeyboardEvent&) override;
+ WebInputEventResult handleMouseWheel(LocalFrame&, const WebMouseWheelEvent&) override;
+ WebInputEventResult handleGestureEvent(const WebGestureEvent&) override;
+ WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
+ WebInputEventResult handleCharEvent(const WebKeyboardEvent&) override;
WebViewImpl* view() const { return m_localRoot->viewImpl(); }

Powered by Google App Engine
This is Rietveld 408576698