Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 6aac6559c687643727297c180bdd93e7f334f5a1..e38da0a04541a6af1ebd951029ae0ff4c417c8b0 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -266,11 +266,11 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent)
return true;
if (mouseEvent.type() == PlatformEvent::MouseMoved)
- handled = overlayMainFrame()->eventHandler().handleMouseMoveEvent(mouseEvent);
+ handled = overlayMainFrame()->eventHandler().handleMouseMoveEvent(mouseEvent) != WebInputEventResult::NotHandled;
if (mouseEvent.type() == PlatformEvent::MousePressed)
- handled = overlayMainFrame()->eventHandler().handleMousePressEvent(mouseEvent);
+ handled = overlayMainFrame()->eventHandler().handleMousePressEvent(mouseEvent) != WebInputEventResult::NotHandled;
if (mouseEvent.type() == PlatformEvent::MouseReleased)
- handled = overlayMainFrame()->eventHandler().handleMouseReleaseEvent(mouseEvent);
+ handled = overlayMainFrame()->eventHandler().handleMouseReleaseEvent(mouseEvent) != WebInputEventResult::NotHandled;
}
if (WebInputEvent::isTouchEventType(inputEvent.type)) {
@@ -287,7 +287,7 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent)
if (inputEvent.type == WebInputEvent::MouseWheel) {
PlatformWheelEvent wheelEvent = PlatformWheelEventBuilder(m_webViewImpl->mainFrameImpl()->frameView(), static_cast<const WebMouseWheelEvent&>(inputEvent));
- handled = overlayMainFrame()->eventHandler().handleWheelEvent(wheelEvent);
+ handled = overlayMainFrame()->eventHandler().handleWheelEvent(wheelEvent) != WebInputEventResult::NotHandled;
}
return handled;

Powered by Google App Engine
This is Rietveld 408576698