Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: content/renderer/render_widget_fullscreen_pepper.cc

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget_fullscreen_pepper.cc
diff --git a/content/renderer/render_widget_fullscreen_pepper.cc b/content/renderer/render_widget_fullscreen_pepper.cc
index 61fc5445cedcf1359fc038179751e2ccaa1a256a..8f2091d08e599180e40b9a4f0eb3c4fcd619c295 100644
--- a/content/renderer/render_widget_fullscreen_pepper.cc
+++ b/content/renderer/render_widget_fullscreen_pepper.cc
@@ -31,6 +31,7 @@ using blink::WebCompositionUnderline;
using blink::WebCursorInfo;
using blink::WebGestureEvent;
using blink::WebInputEvent;
+using blink::WebInputEventResult;
using blink::WebMouseEvent;
using blink::WebMouseWheelEvent;
using blink::WebPoint;
@@ -158,9 +159,9 @@ class PepperWidget : public WebWidget {
void themeChanged() override { NOTIMPLEMENTED(); }
- bool handleInputEvent(const WebInputEvent& event) override {
+ WebInputEventResult handleInputEvent(const WebInputEvent& event) override {
if (!widget_->plugin())
- return false;
+ return WebInputEventResult::NotHandled;
// This cursor info is ignored, we always set the cursor directly from
// RenderWidgetFullscreenPepper::DidChangeCursor.
@@ -208,7 +209,8 @@ class PepperWidget : public WebWidget {
break;
}
}
- return result;
+ return result ? WebInputEventResult::HandledApplication
+ : WebInputEventResult::NotHandled;
}
bool result = widget_->plugin()->HandleInputEvent(event, &cursor);
@@ -243,7 +245,8 @@ class PepperWidget : public WebWidget {
widget_->plugin()->HandleInputEvent(context_menu_event, &cursor);
}
}
- return result;
+ return result ? WebInputEventResult::HandledApplication
+ : WebInputEventResult::NotHandled;
}
private:

Powered by Google App Engine
This is Rietveld 408576698