content/renderer/pepper/pepper_webplugin_impl.cc - Issue 1463823003: Return a enumeration of the state of handling of InputEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | content/renderer/render_widget.cc » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_webplugin_impl.cc

diff --git a/content/renderer/pepper/pepper_webplugin_impl.cc b/content/renderer/pepper/pepper_webplugin_impl.cc

index 2773194caf80bc914b443aab3b3c90a5d3ab8880..e4bf44d685fc6ed9eb1d3197690258a8beccb8b5 100644

--- a/content/renderer/pepper/pepper_webplugin_impl.cc

+++ b/content/renderer/pepper/pepper_webplugin_impl.cc

@@ -219,11 +219,14 @@ void PepperWebPluginImpl::updateVisibility(bool visible) {}

bool PepperWebPluginImpl::acceptsInputEvents() { return true; }

-bool PepperWebPluginImpl::handleInputEvent(const blink::WebInputEvent& event,

- blink::WebCursorInfo& cursor_info) {

+blink::WebInputEventResult PepperWebPluginImpl::handleInputEvent(

+ const blink::WebInputEvent& event,

+ blink::WebCursorInfo& cursor_info) {

if (instance_->FlashIsFullscreenOrPending())

- return false;

- return instance_->HandleInputEvent(event, &cursor_info);

+ return blink::WebInputEventResult::NotHandled;

+ return instance_->HandleInputEvent(event, &cursor_info)

+ ? blink::WebInputEventResult::HandledApplication

+ : blink::WebInputEventResult::NotHandled;

}

void PepperWebPluginImpl::didReceiveResponse(