third_party/WebKit/public/platform/WebInputEventResult.h - Issue 1463823003: Return a enumeration of the state of handling of InputEvents.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebInputEventResult.h

Issue 1463823003: Return a enumeration of the state of handling of InputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build failures and disabled click test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebInputEventResult_h

	6 #define WebInputEventResult_h

	7

	8 namespace blink {

	9

	10 enum class WebInputEventResult {

	11 NotHandled, // consumed by neither script or default handler

	12 HandledScript, // consumed by a script handler (ie. preventDefault called)
	Rick Byers 2015/11/23 21:59:55 I wonder, is "script" too restrictive here? What I wonder, is "script" too restrictive here? What if we have a case where we handle the event in C++ outside the default handler. I know this violates Anne's model for DOM events, but I think a couple places may exist and it may be necessary for some layered-platform scenarios. So we could call this HandledNonDefault or maybe even just Handled. Or maybe 'Script' is the best way to describe this concisely and we should just clarify in the comment that in rare cases this may still mean C++ code. Or maybe (after looking at your use cases) the real distinction here IS script vs. internal. In which case HandledScript vs. HandledInternal may be the right terminology. The key question is: for all cases where you're saying HandledDefaultHandler, are we sure that logic runs only when the event has gone unhandled in JS, and is never run via dispatching a synthetic event from JS.
	13 HandledDefaultHandler // consumed by a default handler

	14 };

	15

	16 } // namespace blink

	17

	18 #endif // WebInputEventResult_h

OLD	NEW