Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: content/browser/devtools/protocol/page_handler.h

Issue 1463813003: DevTools: optimize screencast for slower devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just count frames Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 NavigationEntries* entries); 58 NavigationEntries* entries);
59 59
60 Response NavigateToHistoryEntry(int entry_id); 60 Response NavigateToHistoryEntry(int entry_id);
61 61
62 Response CaptureScreenshot(DevToolsCommandId command_id); 62 Response CaptureScreenshot(DevToolsCommandId command_id);
63 63
64 Response CanScreencast(bool* result); 64 Response CanScreencast(bool* result);
65 Response StartScreencast(const std::string* format, 65 Response StartScreencast(const std::string* format,
66 const int* quality, 66 const int* quality,
67 const int* max_width, 67 const int* max_width,
68 const int* max_height); 68 const int* max_height,
69 const int* every_nth_frame);
69 Response StopScreencast(); 70 Response StopScreencast();
70 Response ScreencastFrameAck(int frame_number); 71 Response ScreencastFrameAck();
71 72
72 Response HandleJavaScriptDialog(bool accept, const std::string* prompt_text); 73 Response HandleJavaScriptDialog(bool accept, const std::string* prompt_text);
73 74
74 Response QueryUsageAndQuota(DevToolsCommandId command_id, 75 Response QueryUsageAndQuota(DevToolsCommandId command_id,
75 const std::string& security_origin); 76 const std::string& security_origin);
76 77
77 Response SetColorPickerEnabled(bool enabled); 78 Response SetColorPickerEnabled(bool enabled);
78 79
79 private: 80 private:
80 WebContentsImpl* GetWebContents(); 81 WebContentsImpl* GetWebContents();
(...skipping 18 matching lines...) Expand all
99 const NotificationSource& source, 100 const NotificationSource& source,
100 const NotificationDetails& details) override; 101 const NotificationDetails& details) override;
101 102
102 bool enabled_; 103 bool enabled_;
103 104
104 bool screencast_enabled_; 105 bool screencast_enabled_;
105 std::string screencast_format_; 106 std::string screencast_format_;
106 int screencast_quality_; 107 int screencast_quality_;
107 int screencast_max_width_; 108 int screencast_max_width_;
108 int screencast_max_height_; 109 int screencast_max_height_;
110 int capture_every_nth_frame_;
109 int capture_retry_count_; 111 int capture_retry_count_;
110 bool has_compositor_frame_metadata_; 112 bool has_compositor_frame_metadata_;
111 cc::CompositorFrameMetadata next_compositor_frame_metadata_; 113 cc::CompositorFrameMetadata next_compositor_frame_metadata_;
112 cc::CompositorFrameMetadata last_compositor_frame_metadata_; 114 cc::CompositorFrameMetadata last_compositor_frame_metadata_;
113 int screencast_frame_sent_; 115 int frame_counter_;
114 int screencast_frame_acked_; 116 int frames_in_flight_;
115 bool processing_screencast_frame_;
116 117
117 scoped_ptr<ColorPicker> color_picker_; 118 scoped_ptr<ColorPicker> color_picker_;
118 119
119 RenderFrameHostImpl* host_; 120 RenderFrameHostImpl* host_;
120 scoped_ptr<Client> client_; 121 scoped_ptr<Client> client_;
121 NotificationRegistrar registrar_; 122 NotificationRegistrar registrar_;
122 base::WeakPtrFactory<PageHandler> weak_factory_; 123 base::WeakPtrFactory<PageHandler> weak_factory_;
123 124
124 DISALLOW_COPY_AND_ASSIGN(PageHandler); 125 DISALLOW_COPY_AND_ASSIGN(PageHandler);
125 }; 126 };
126 127
127 } // namespace page 128 } // namespace page
128 } // namespace devtools 129 } // namespace devtools
129 } // namespace content 130 } // namespace content
130 131
131 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_ 132 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_PAGE_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/devtools/protocol/page_handler.cc » ('j') | content/browser/devtools/protocol/page_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698