Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463813003: DevTools: optimize screencast for slower devices. (Closed)

Created:
5 years, 1 month ago by pfeldman
Modified:
5 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: optimize screencast for slower devices. Committed: https://crrev.com/92175843b65f74040377af5c983147e546d9cef1 Cr-Commit-Position: refs/heads/master@{#361000}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : just count frames #

Total comments: 2

Patch Set 4 : using sessions now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -34 lines) Patch
M content/browser/devtools/protocol/page_handler.h View 1 2 3 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 2 3 11 chunks +27 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
pfeldman
5 years, 1 month ago (2015-11-20 20:42:21 UTC) #2
dgozman
https://codereview.chromium.org/1463813003/diff/20001/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/1463813003/diff/20001/content/browser/devtools/protocol/page_handler.cc#newcode386 content/browser/devtools/protocol/page_handler.cc:386: static int global_frame_counter = 0; With two different screencasts ...
5 years, 1 month ago (2015-11-20 22:53:23 UTC) #3
pfeldman
https://codereview.chromium.org/1463813003/diff/20001/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/1463813003/diff/20001/content/browser/devtools/protocol/page_handler.cc#newcode386 content/browser/devtools/protocol/page_handler.cc:386: static int global_frame_counter = 0; On 2015/11/20 22:53:23, dgozman ...
5 years, 1 month ago (2015-11-20 23:18:26 UTC) #4
pfeldman
PTAL
5 years, 1 month ago (2015-11-21 01:27:57 UTC) #5
dgozman
lgtm https://codereview.chromium.org/1463813003/diff/40001/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/1463813003/diff/40001/content/browser/devtools/protocol/page_handler.cc#newcode306 content/browser/devtools/protocol/page_handler.cc:306: frames_in_flight_ = 0; Let's pass session id around. ...
5 years, 1 month ago (2015-11-21 02:03:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463813003/60001
5 years, 1 month ago (2015-11-21 02:44:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-21 04:00:42 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 04:01:26 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/92175843b65f74040377af5c983147e546d9cef1
Cr-Commit-Position: refs/heads/master@{#361000}

Powered by Google App Engine
This is Rietveld 408576698