Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 14638003: deprecate WriteAscii and MayContainNonAscii (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

deprecate WriteAscii and MayContainNonAscii R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M include/v8.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 12 chunks +17 lines, -19 lines 0 comments Download
M test/cctest/test-debug.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
lgtm
7 years, 7 months ago (2013-04-30 12:11:24 UTC) #1
dcarney
7 years, 7 months ago (2013-05-03 06:47:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698