Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463793004: Add null check to AXLayoutObject::computeAccessibilityIsIgnored (Closed)

Created:
5 years, 1 month ago by dmazzoni
Modified:
5 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check to AXLayoutObject::computeAccessibilityIsIgnored BUG=558198 Committed: https://crrev.com/7950ba2733bddc2498f01733a8224bfe5d828899 Cr-Commit-Position: refs/heads/master@{#360929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1467423002 Patch 1

Messages

Total messages: 7 (2 generated)
dmazzoni
See the stack trace in the bug, this one looks pretty straightforward
5 years, 1 month ago (2015-11-20 21:05:25 UTC) #2
aboxhall
lgtm
5 years, 1 month ago (2015-11-20 21:12:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463793004/1
5 years, 1 month ago (2015-11-20 22:02:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 22:17:59 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 23:03:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7950ba2733bddc2498f01733a8224bfe5d828899
Cr-Commit-Position: refs/heads/master@{#360929}

Powered by Google App Engine
This is Rietveld 408576698