Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1463763002: Add event name to bare removeEventListener(listener) calls (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
stevenjb, dgozman, ddorwin
CC:
chromium-reviews, eric.carlson_apple.com, apavlov+blink_chromium.org, arv+watch_chromium.org, caseq+blink_chromium.org, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, dbeam+watch-options_chromium.org, philipj_slow, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, lushnikov+blink_chromium.org, oshima+watch_chromium.org, michaelpg+watch-options_chromium.org, plundblad+watch_chromium.org, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, pfeldman, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add event name to bare removeEventListener(listener) calls This mistake was possible because removeEventListener's arguments are all optional, and these calls would throw exceptions if the argument were non-optional. Since these code paths supposedly current work, removing the event listeners cannot be critical, but do it anyway as was originally intended. BUG=353484 Committed: https://crrev.com/4a653108efe1d4e3560b48f44df2634ade6967d1 Cr-Commit-Position: refs/heads/master@{#360949}

Patch Set 1 #

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463763002/1
5 years, 1 month ago (2015-11-20 10:03:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 11:56:28 UTC) #4
philipj_slow
PTAL, I'd like to land this before https://codereview.chromium.org/1461993002/ stevenjb@:chrome/browser/* dgozman@: third_party/WebKit/Source/devtools/* ddorwin@: third_party/WebKit/LayoutTests/* (since all ...
5 years, 1 month ago (2015-11-20 12:23:40 UTC) #6
stevenjb
c/b/ui/webui owner lgtm
5 years, 1 month ago (2015-11-20 16:57:25 UTC) #7
dgozman
devtools lgtm
5 years, 1 month ago (2015-11-20 17:20:40 UTC) #8
ddorwin
third_party/WebKit/LayoutTests/ LGTM
5 years, 1 month ago (2015-11-20 17:22:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463763002/1
5 years, 1 month ago (2015-11-20 21:52:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/120870)
5 years, 1 month ago (2015-11-20 22:06:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463763002/1
5 years, 1 month ago (2015-11-20 23:23:57 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 23:31:02 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 23:31:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a653108efe1d4e3560b48f44df2634ade6967d1
Cr-Commit-Position: refs/heads/master@{#360949}

Powered by Google App Engine
This is Rietveld 408576698