ChromeOS: This CL fixes bug in UserManager::GetKnownUserAccountId .

chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

Index: chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc b/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
index 196b81ba4dfad12dde2bab45922163264e41537e..4d00564d9d22a01d642ba3a8784aa6d7248ed084 100644
--- a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
+++ b/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
@@ -77,7 +77,9 @@ void ChromeUserSelectionScreen::OnDeviceLocalAccountsChanged() {
 
 void ChromeUserSelectionScreen::CheckForPublicSessionDisplayNameChange(
     policy::DeviceLocalAccountPolicyBroker* broker) {
-  const AccountId& account_id = GetAccountIdOfKnownUser(broker->user_id());
+  const AccountId& account_id =

[achuithb, 2015/11/20 18:46:51]

Shouldn't this be AccountId account_id=

Why do you want a const reference to a temporary? I realize this works, but
isn't it confusing?

+      user_manager::UserManager::GetKnownUserAccountId(broker->user_id(),
+                                                       std::string());
   DCHECK(account_id.is_valid());
   const std::string& display_name = broker->GetDisplayName();
   if (display_name == public_session_display_names_[account_id])
@@ -107,7 +109,9 @@ void ChromeUserSelectionScreen::CheckForPublicSessionDisplayNameChange(
 
 void ChromeUserSelectionScreen::CheckForPublicSessionLocalePolicyChange(
     policy::DeviceLocalAccountPolicyBroker* broker) {
-  const AccountId& account_id = GetAccountIdOfKnownUser(broker->user_id());
+  const AccountId& account_id =

[achuithb, 2015/11/20 18:46:51]

Shouldn't this be AccountId account_id =

+      user_manager::UserManager::GetKnownUserAccountId(broker->user_id(),
+                                                       std::string());
   DCHECK(account_id.is_valid());
   const policy::PolicyMap::Entry* entry =
       broker->core()->store()->policy_map().Get(policy::key::kSessionLocales);