third_party/WebKit/Source/core/testing/Internals.cpp - Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/testing/Internals.h ('K') | « third_party/WebKit/Source/core/testing/Internals.h ('k') | third_party/WebKit/Source/core/testing/Internals.idl » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/Internals.cpp

diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp

index 1b704fef525a4712436a5dc8450d2a1f5907ff91..e4cf3953f1fe9e1e5cb9a9a1ab2b881b2e66d845 100644

--- a/third_party/WebKit/Source/core/testing/Internals.cpp

+++ b/third_party/WebKit/Source/core/testing/Internals.cpp

@@ -2423,11 +2423,13 @@ unsigned Internals::canvasFontCacheMaxFonts()

return CanvasFontCache::maxFonts();

}

+/*

bokan 2015/11/24 20:59:24 Remove rather than comment

oshima 2015/11/24 23:42:10 Sorry, my mistake. Looks like I forgot or failed t

ClientRect* Internals::boundsInViewportSpace(Element* element)

{

ASSERT(element);

return ClientRect::create(element->boundsInViewportSpace());

}

+*/

void Internals::setScrollChain(

ScrollState* scrollState, const WillBeHeapVector<RefPtrWillBeMember<Element>>& elements, ExceptionState&)