content/renderer/render_view_impl.cc - Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_plugin_instance_impl.cc ('K') | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | third_party/WebKit/Source/core/testing/Internals.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 5149177b16217ae5003bd2a92f23fb7cce857d21..c89eadc9f417f720f10c33bb24982619e2417313 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1928,7 +1928,7 @@ void RenderViewImpl::focusedNodeChanged(const WebNode& fromNode,

bool is_editable = false;

if (!toNode.isNull() && toNode.isElementNode()) {

WebElement element = const_cast<WebNode&>(toNode).to<WebElement>();

- node_bounds = gfx::Rect(element.boundsInViewportSpace());

+ node_bounds = gfx::Rect(element.boundsInViewport());

is_editable = element.isEditable();

}

Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, is_editable,