Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1463703002: XFA: Fix a few fxjse warnings. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M xfa/src/fxjse/src/class.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/dynprop.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Getting tired of these.
5 years, 1 month ago (2015-11-20 07:31:00 UTC) #2
Tom Sepez
LGTM. I am tired of these, too.
5 years, 1 month ago (2015-11-20 17:10:55 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-20 22:14:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f7dc2be794e981a2728b2ae1eddf4a32179db9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698