Issue 14637011: Add a new mode to render_pictures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14637011: Add a new mode to render_pictures. (Closed)

Created:
7 years, 7 months ago by scroggo

Modified:
7 years, 7 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add a new mode to render_pictures. In the new mode, if an SKP file has encoded bitmap data, draw the data to a file with the appropriate name. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9001

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comments #

Patch Set 3 : Respond to comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -1 line)			Patch
	M	tools/render_pictures_main.cpp	View	1 2	5 chunks	+104 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM with one comment. https://codereview.chromium.org/14637011/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.chromium.org/14637011/diff/1/tools/render_pictures_main.cpp#newcode104 tools/render_pictures_main.cpp:104: gInputFileName.remove(gInputFileName.size() - 4, 4); I'd ...

7 years, 7 months ago (2013-05-02 15:34:46 UTC) #2

scroggo

https://codereview.chromium.org/14637011/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.chromium.org/14637011/diff/1/tools/render_pictures_main.cpp#newcode104 tools/render_pictures_main.cpp:104: gInputFileName.remove(gInputFileName.size() - 4, 4); On 2013/05/02 15:34:46, borenet wrote: ...

7 years, 7 months ago (2013-05-03 20:43:07 UTC) #3

scroggo

7 years, 7 months ago (2013-05-03 20:43:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r9001 (presubmit successful).

Expand Messages | Collapse Messages