Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1463673003: Use w3c test harness in editing/selection/vertical-*.html tests 2/3 (Closed)

Created:
5 years, 1 month ago by yosin_UTC9
Modified:
5 years ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use w3c test harness in editing/selection/vertical-*.html tests 2/3 This patch makes editing/selection/vertical-*.html to use w3c test harness rather than pixel match for ease of maintain. This is the first patch of three patches of rewriting vertical-*.html. Due by Windows command prompt limitation, we can't upload once. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/af6fd5d7ea55f301c577f559e4a1f8ce9fc37b68 Cr-Commit-Position: refs/heads/master@{#361252}

Patch Set 1 : 2015-11-20T17:03:46 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -483 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/vertical-lr-ltr-extend-line-forward-br.html View 1 chunk +17 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-ltr-extend-line-forward-br.html View 1 chunk +16 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-ltr-extend-line-forward-p.html View 1 chunk +18 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html View 1 chunk +20 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
5 years, 1 month ago (2015-11-20 08:35:43 UTC) #3
yoichio
lgtm
5 years, 1 month ago (2015-11-24 02:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463673003/1
5 years ago (2015-11-24 03:36:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 04:31:07 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 04:32:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af6fd5d7ea55f301c577f559e4a1f8ce9fc37b68
Cr-Commit-Position: refs/heads/master@{#361252}

Powered by Google App Engine
This is Rietveld 408576698