Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: util/win/process_info.cc

Issue 1463633002: win: Avoid some more clang complaints (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@vm-counters-struct
Patch Set: {} Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/win/exception_handler_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/process_info.cc
diff --git a/util/win/process_info.cc b/util/win/process_info.cc
index 50f947cef68551aa3abcaa9cb2295120a4840291..3e048cf016d7335377c9b1f36dff32492e9bd7fa 100644
--- a/util/win/process_info.cc
+++ b/util/win/process_info.cc
@@ -222,7 +222,7 @@ template <class Traits>
bool ReadProcessData(HANDLE process,
WinVMAddress peb_address_vmaddr,
ProcessInfo* process_info) {
- Traits::Pointer peb_address;
+ typename Traits::Pointer peb_address;
if (!AssignIfInRange(&peb_address, peb_address_vmaddr)) {
LOG(ERROR) << base::StringPrintf("peb address 0x%x out of range",
peb_address_vmaddr);
@@ -273,8 +273,10 @@ bool ReadProcessData(HANDLE process,
// Walk the PEB LDR structure (doubly-linked list) to get the list of loaded
// modules. We use this method rather than EnumProcessModules to get the
// modules in initialization order rather than memory order.
- Traits::Pointer last = peb_ldr_data.InInitializationOrderModuleList.Blink;
- for (Traits::Pointer cur = peb_ldr_data.InInitializationOrderModuleList.Flink;
+ typename Traits::Pointer last =
+ peb_ldr_data.InInitializationOrderModuleList.Blink;
+ for (typename Traits::Pointer cur =
+ peb_ldr_data.InInitializationOrderModuleList.Flink;
;
cur = ldr_data_table_entry.InInitializationOrderLinks.Flink) {
// |cur| is the pointer to the LIST_ENTRY embedded in the
« no previous file with comments | « util/win/exception_handler_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698