Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: client/crashpad_client_win.cc

Issue 1463633002: win: Avoid some more clang complaints (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@vm-counters-struct
Patch Set: {} Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_client_win.cc
diff --git a/client/crashpad_client_win.cc b/client/crashpad_client_win.cc
index 2ef07a7e5daddb24c3d03d0dfc322833b110839a..40a856f33f03ba03cbeb2c57c0e6ae59a30b91f0 100644
--- a/client/crashpad_client_win.cc
+++ b/client/crashpad_client_win.cc
@@ -368,7 +368,7 @@ bool CrashpadClient::UseHandler() {
reinterpret_cast<WinVMAddress>(&g_critical_section_with_debug_info);
}
- ServerToClientMessage response = {0};
+ ServerToClientMessage response = {};
if (!SendToCrashHandlerServer(ipc_pipe_, message, &response)) {
return false;
@@ -408,7 +408,7 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {
// Create a fake EXCEPTION_POINTERS to give the handler something to work
// with.
- EXCEPTION_POINTERS exception_pointers = {0};
+ EXCEPTION_POINTERS exception_pointers = {};
// This is logically const, but EXCEPTION_POINTERS does not declare it as
// const, so we have to cast that away from the argument.
@@ -421,7 +421,7 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {
// some of the top nibble set, so we make sure to pick a value that doesn't,
// so as to be unlikely to conflict.
const uint32_t kSimulatedExceptionCode = 0x517a7ed;
- EXCEPTION_RECORD record = {0};
+ EXCEPTION_RECORD record = {};
record.ExceptionCode = kSimulatedExceptionCode;
#if defined(ARCH_CPU_64_BITS)
record.ExceptionAddress = reinterpret_cast<void*>(context.Rip);
« no previous file with comments | « no previous file | util/win/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698