win: Avoid some more clang complaints

util/win/process_info.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 204 matching lines @@
     *peb_size = sizeof(process_types::PEB<process_types::internal::Traits32>);
   }
 
   return true;
 }
 
 template <class Traits>
 bool ReadProcessData(HANDLE process,
                      WinVMAddress peb_address_vmaddr,
                      ProcessInfo* process_info) {
-  Traits::Pointer peb_address;
+  typename Traits::Pointer peb_address;
   if (!AssignIfInRange(&peb_address, peb_address_vmaddr)) {
     LOG(ERROR) << base::StringPrintf("peb address 0x%x out of range",
                                      peb_address_vmaddr);
     return false;
   }
 
   // Try to read the process environment block.
   process_types::PEB<Traits> peb;
   if (!ReadStruct(process, peb_address, &peb))
     return false;
@@ skipping 30 matching lines @@
     return false;
   }
   module.dll_base = ldr_data_table_entry.DllBase;
   module.size = ldr_data_table_entry.SizeOfImage;
   module.timestamp = ldr_data_table_entry.TimeDateStamp;
   process_info->modules_.push_back(module);
 
   // Walk the PEB LDR structure (doubly-linked list) to get the list of loaded
   // modules. We use this method rather than EnumProcessModules to get the
   // modules in initialization order rather than memory order.
-  Traits::Pointer last = peb_ldr_data.InInitializationOrderModuleList.Blink;
-  for (Traits::Pointer cur = peb_ldr_data.InInitializationOrderModuleList.Flink;
+  typename Traits::Pointer last =
+      peb_ldr_data.InInitializationOrderModuleList.Blink;
+  for (typename Traits::Pointer cur =
+           peb_ldr_data.InInitializationOrderModuleList.Flink;
        ;
        cur = ldr_data_table_entry.InInitializationOrderLinks.Flink) {
     // |cur| is the pointer to the LIST_ENTRY embedded in the
     // LDR_DATA_TABLE_ENTRY, in the target process's address space. So we need
     // to read from the target, and also offset back to the beginning of the
     // structure.
     if (!ReadStruct(process,
                     static_cast<WinVMAddress>(cur) -
                         offsetof(process_types::LDR_DATA_TABLE_ENTRY<Traits>,
                                  InInitializationOrderLinks),
@@ skipping 393 matching lines @@
     } else {
       result.push_back(as_ranges[i]);
     }
     DCHECK(result.back().IsValid());
   }
 
   return result;
 }
 
 }  // namespace crashpad