Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 14636012: Move ShellWindowGeometryCache into apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: PKS dependency Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/extensions/shell_window.h" 5 #include "chrome/browser/ui/extensions/shell_window.h"
6 6
7 #include "apps/shell_window_geometry_cache.h"
7 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
8 #include "base/values.h" 9 #include "base/values.h"
9 #include "chrome/browser/extensions/app_window_contents.h" 10 #include "chrome/browser/extensions/app_window_contents.h"
10 #include "chrome/browser/extensions/extension_process_manager.h" 11 #include "chrome/browser/extensions/extension_process_manager.h"
11 #include "chrome/browser/extensions/extension_system.h" 12 #include "chrome/browser/extensions/extension_system.h"
12 #include "chrome/browser/extensions/image_loader.h" 13 #include "chrome/browser/extensions/image_loader.h"
13 #include "chrome/browser/extensions/shell_window_geometry_cache.h"
14 #include "chrome/browser/extensions/shell_window_registry.h" 14 #include "chrome/browser/extensions/shell_window_registry.h"
15 #include "chrome/browser/extensions/suggest_permission_util.h" 15 #include "chrome/browser/extensions/suggest_permission_util.h"
16 #include "chrome/browser/favicon/favicon_tab_helper.h" 16 #include "chrome/browser/favicon/favicon_tab_helper.h"
17 #include "chrome/browser/file_select_helper.h" 17 #include "chrome/browser/file_select_helper.h"
18 #include "chrome/browser/lifetime/application_lifetime.h" 18 #include "chrome/browser/lifetime/application_lifetime.h"
19 #include "chrome/browser/media/media_capture_devices_dispatcher.h" 19 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
20 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/browser/sessions/session_id.h" 21 #include "chrome/browser/sessions/session_id.h"
22 #include "chrome/browser/ui/browser.h" 22 #include "chrome/browser/ui/browser.h"
23 #include "chrome/browser/ui/browser_finder.h" 23 #include "chrome/browser/ui/browser_finder.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 if (bounds.height() == 0) 127 if (bounds.height() == 0)
128 bounds.set_height(kDefaultHeight); 128 bounds.set_height(kDefaultHeight);
129 129
130 // If left and top are left undefined, the native shell window will center 130 // If left and top are left undefined, the native shell window will center
131 // the window on the main screen in a platform-defined manner. 131 // the window on the main screen in a platform-defined manner.
132 132
133 ui::WindowShowState cached_state = ui::SHOW_STATE_DEFAULT; 133 ui::WindowShowState cached_state = ui::SHOW_STATE_DEFAULT;
134 if (!params.window_key.empty()) { 134 if (!params.window_key.empty()) {
135 window_key_ = params.window_key; 135 window_key_ = params.window_key;
136 136
137 extensions::ShellWindowGeometryCache* cache = 137 apps::ShellWindowGeometryCache* cache =
138 extensions::ExtensionSystem::Get(profile())-> 138 apps::ShellWindowGeometryCache::Get(profile());
139 shell_window_geometry_cache(); 139
140 gfx::Rect cached_bounds; 140 gfx::Rect cached_bounds;
141 if (cache->GetGeometry(extension()->id(), params.window_key, 141 if (cache->GetGeometry(extension()->id(), params.window_key,
142 &cached_bounds, &cached_state)) { 142 &cached_bounds, &cached_state)) {
143 bounds = cached_bounds; 143 bounds = cached_bounds;
144 } 144 }
145 } 145 }
146 146
147 CreateParams new_params = params; 147 CreateParams new_params = params;
148 148
149 gfx::Size& minimum_size = new_params.minimum_size; 149 gfx::Size& minimum_size = new_params.minimum_size;
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 rvh->Send(new ExtensionMsg_AddMessageToConsole( 562 rvh->Send(new ExtensionMsg_AddMessageToConsole(
563 rvh->GetRoutingID(), level, message)); 563 rvh->GetRoutingID(), level, message));
564 } 564 }
565 565
566 void ShellWindow::SaveWindowPosition() { 566 void ShellWindow::SaveWindowPosition() {
567 if (window_key_.empty()) 567 if (window_key_.empty())
568 return; 568 return;
569 if (!native_app_window_) 569 if (!native_app_window_)
570 return; 570 return;
571 571
572 extensions::ShellWindowGeometryCache* cache = 572 apps::ShellWindowGeometryCache* cache =
573 extensions::ExtensionSystem::Get(profile())-> 573 apps::ShellWindowGeometryCache::Get(profile());
574 shell_window_geometry_cache();
575 574
576 gfx::Rect bounds = native_app_window_->GetRestoredBounds(); 575 gfx::Rect bounds = native_app_window_->GetRestoredBounds();
577 bounds.Inset(native_app_window_->GetFrameInsets()); 576 bounds.Inset(native_app_window_->GetFrameInsets());
578 ui::WindowShowState window_state = native_app_window_->GetRestoredState(); 577 ui::WindowShowState window_state = native_app_window_->GetRestoredState();
579 cache->SaveGeometry(extension()->id(), window_key_, bounds, window_state); 578 cache->SaveGeometry(extension()->id(), window_key_, bounds, window_state);
580 } 579 }
581 580
582 // static 581 // static
583 SkRegion* ShellWindow::RawDraggableRegionsToSkRegion( 582 SkRegion* ShellWindow::RawDraggableRegionsToSkRegion(
584 const std::vector<extensions::DraggableRegion>& regions) { 583 const std::vector<extensions::DraggableRegion>& regions) {
585 SkRegion* sk_region = new SkRegion; 584 SkRegion* sk_region = new SkRegion;
586 for (std::vector<extensions::DraggableRegion>::const_iterator iter = 585 for (std::vector<extensions::DraggableRegion>::const_iterator iter =
587 regions.begin(); 586 regions.begin();
588 iter != regions.end(); ++iter) { 587 iter != regions.end(); ++iter) {
589 const extensions::DraggableRegion& region = *iter; 588 const extensions::DraggableRegion& region = *iter;
590 sk_region->op( 589 sk_region->op(
591 region.bounds.x(), 590 region.bounds.x(),
592 region.bounds.y(), 591 region.bounds.y(),
593 region.bounds.right(), 592 region.bounds.right(),
594 region.bounds.bottom(), 593 region.bounds.bottom(),
595 region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op); 594 region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
596 } 595 }
597 return sk_region; 596 return sk_region;
598 } 597 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698