sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart - Issue 14636002: Make TypeMask an interface and start hiding implementation details of FlatTypeMask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 14636002: Make TypeMask an interface and start hiding implementation details of FlatTypeMask. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (revision 22167)

+++ sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (working copy)

@@ -2275,8 +2275,8 @@

if (mask != null) {

// If the mask is empty it doesn't contain a noSuchMethod

// handler -- not even if it is nullable.

- if (mask.isEmpty) continue;

- receiverClass = mask.base.element;

+ receiverClass = mask.topClass();

kasperl 2013/04/30 14:03:24 Here we shouldn't compute a receiver class but rat

ngeoffray 2013/05/01 12:56:16 Done.

+ if (receiverClass == null) continue;

}

// If the receiver class is guaranteed to have a member that

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('J')