Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1463593003: Status file update (vm only tests SkipByDesign). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Status file update (vm only tests SkipByDesign). Follow-up to https://codereview.chromium.org/1464833002/. Rather than ignore, mark as `SkipByDesign` as CLI tests are designed for the VM. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/968617b67afc1405096dbe9497a04c8edb929ebc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-20 17:40:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 1 month ago (2015-11-20 17:43:30 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-20 18:19:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
968617b67afc1405096dbe9497a04c8edb929ebc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698