Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4887)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 1463583004: [Contextual Search] Trigger translation on long-press. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tiny tweak. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index 1ba524a0de7ad80a6d4156abdab3e264fa35f871..de577654a34b59071b7206e3213eba02ca191ff0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -33,12 +33,16 @@ public class ContextualSearchFieldTrial {
// Translation.
@VisibleForTesting
static final String DISABLE_FORCE_TRANSLATION_ONEBOX = "disable_force_translation_onebox";
+ @VisibleForTesting
+ static final String DISABLE_AUTO_DETECT_TRANSLATION_ONEBOX =
+ "disable_auto_detect_translation_onebox";
// Cached values to avoid repeated and redundant JNI operations.
private static Boolean sEnabled;
private static Boolean sIsPeekPromoEnabled;
private static Integer sPeekPromoMaxCount;
private static Boolean sDisableForceTranslationOnebox;
+ private static Boolean sDisableAutoDetectTranslationOnebox;
/**
* Don't instantiate.
@@ -139,6 +143,18 @@ public class ContextualSearchFieldTrial {
return sDisableForceTranslationOnebox.booleanValue();
}
+ /**
+ * @return Whether forcing a translation Onebox based on auto-detection of the source language
+ * is disabled.
+ */
+ static boolean disableAutoDetectTranslationOnebox() {
+ if (sDisableAutoDetectTranslationOnebox == null) {
+ sDisableAutoDetectTranslationOnebox = getBooleanParam(
+ DISABLE_AUTO_DETECT_TRANSLATION_ONEBOX);
+ }
+ return sDisableAutoDetectTranslationOnebox.booleanValue();
+ }
+
// --------------------------------------------------------------------------------------------
// Helpers.
// --------------------------------------------------------------------------------------------
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698