[Contextual Search] Trigger translation on long-press.

chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextualsearch;
 
 import android.app.Activity;
 import android.content.Context;
 import android.view.View;
 import android.view.ViewGroup;
@@ skipping 473 matching lines @@
                 mNetworkCommunicator.getBasePageUrl())) {
             mNetworkCommunicator.startSearchTermResolutionRequest(
                     mSelectionController.getSelectedText());
             didRequestSurroundings = true;
             // Cache the target languages in case they are needed for translation.
             if (!mPolicy.disableForceTranslationOnebox()) getReadableLanguages();
         } else {
             boolean shouldPrefetch = mPolicy.shouldPrefetchSearchResult(isTap);
             mSearchRequest = new ContextualSearchRequest(mSelectionController.getSelectedText(),
                     null, shouldPrefetch);
-            // TODO(donnd): figure out a way to do translation on long-press selections.
+            // Always trigger translation using auto-detect when we're not resolving,
+            // unless disabled by policy.
+            boolean doForceTranslate = !mPolicy.disableAutoDetectTranslationOnebox();

[pedro (no code reviews), 2015/11/20 23:56:25]

Nit: rename doForceTranslate to shouldAutoDetectTranslation?

[Donn Denman, 2015/11/21 01:14:00]

Done.

+            if (doForceTranslate) {
+                // Use the empty string for the source language in order to trigger auto-detect.
+                // The translation one-box won't actually show when the source text ends up being
+                // the same as the target text, so we err on over-triggering.
+                mSearchRequest.forceTranslation("",

[pedro (no code reviews), 2015/11/20 23:56:25]

Nit: Similarly, consider having a new CSRequest method called
autoDetectTranslation() or something, because passing an empty string is kinda
obscure.

[Donn Denman, 2015/11/21 01:14:00]

Done.

+                        mPolicy.bestTargetLanguage(getWritableLanguages()));
+                // TODO(donnd): Do we really want to log only when translating on long-press?
+                ContextualSearchUma.logTranslateOnebox(doForceTranslate);
+            }
             mDidStartLoadingResolvedSearchRequest = false;
             mSearchPanel.displaySearchTerm(mSelectionController.getSelectedText());
             if (shouldPrefetch) loadSearchUrl();
         }
 
         if (!didRequestSurroundings) {
             // Gather surrounding text for Icing integration, which will make the selection and
             // a shorter version of the surroundings available for Conversational Search.
             // Although the surroundings are extracted, they will not be sent to the server as
             // part of search term resolution, just sent to Icing which keeps them local until
@@ skipping 787 matching lines @@
     private native void nativeDestroy(long nativeContextualSearchManager);
     private native void nativeStartSearchTermResolutionRequest(long nativeContextualSearchManager,
             String selection, boolean useResolvedSearchTerm, ContentViewCore baseContentViewCore,
             boolean maySendBasePageUrl);
     private native void nativeGatherSurroundingText(long nativeContextualSearchManager,
             String selection, boolean useResolvedSearchTerm, ContentViewCore baseContentViewCore,
             boolean maySendBasePageUrl);
     private native String nativeGetTargetLanguage(long nativeContextualSearchManager);
     private native String nativeGetAcceptLanguages(long nativeContextualSearchManager);
 }