Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_decider.h

Issue 1463583003: Move adding Lo-Fi directives from DRPRequestOptions to ContentLoFiDecider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing tbansal comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_decider.h
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_decider.h b/components/data_reduction_proxy/content/browser/content_lofi_decider.h
index 222fedde8a7d04e129adb9702d2917135c702313..01e037714efcd42e70b4105e3c20532caf433539 100644
--- a/components/data_reduction_proxy/content/browser/content_lofi_decider.h
+++ b/components/data_reduction_proxy/content/browser/content_lofi_decider.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
namespace net {
+class HttpRequestHeaders;
class URLRequest;
}
@@ -17,14 +18,19 @@ namespace data_reduction_proxy {
// Class responsible for deciding whether a request should be requested with low
// fidelity (Lo-Fi) or not. Relies on the Lo-Fi mode state stored in the
// request's content::ResourceRequestInfo, which must be fetched using
-// content::ResourceRequestInfo::ForRequest. Owned by DataReductionProxyIOData
-// and should be called on the IO thread.
+// content::ResourceRequestInfo::ForRequest. Lo-Fi mode will not be enabled for
+// requests that don't have a ResourceRequestInfo, such as background requests.
+// Owned by DataReductionProxyIOData and should be called on the IO thread.
class ContentLoFiDecider : public LoFiDecider {
public:
ContentLoFiDecider();
~ContentLoFiDecider() override;
+ // LoFiDecider implementation:
bool IsUsingLoFiMode(const net::URLRequest& request) const override;
+ bool MaybeAddLoFiDirectiveToHeaders(
+ const net::URLRequest& request,
+ net::HttpRequestHeaders* headers) const override;
private:
DISALLOW_COPY_AND_ASSIGN(ContentLoFiDecider);

Powered by Google App Engine
This is Rietveld 408576698