third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h - Issue 1463513002: Move application of filter effect boundaries to a helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

Issue 1463513002: Move application of filter effect boundaries to a helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FETile.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FETile.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

index a24e7756fc88d8fb831fcf80590cc94eb124a122..e95da8c6f73a2697c6c6c471a7e2f0f12a66fb54 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

@@ -124,6 +124,7 @@ public:

FloatRect effectBoundaries() const { return m_effectBoundaries; }

void setEffectBoundaries(const FloatRect& effectBoundaries) { m_effectBoundaries = effectBoundaries; }

+ void applyEffectBoundaries(FloatRect&) const;

Stephen White 2015/11/19 14:54:34 I'm not a fan of non-const-refs as arguments, sinc

fs 2015/11/19 15:48:09 Done.

Filter* filter() { return m_filter; }

const Filter* filter() const { return m_filter; }