Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

Issue 1463513002: Move application of filter effect boundaries to a helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com> 2 * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com>
3 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 3 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * Copyright (C) 2013 Google Inc. All rights reserved. 5 * Copyright (C) 2013 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void setHasWidth(bool value) { m_hasWidth = value; } 117 void setHasWidth(bool value) { m_hasWidth = value; }
118 118
119 bool hasHeight() const { return m_hasHeight; } 119 bool hasHeight() const { return m_hasHeight; }
120 void setHasHeight(bool value) { m_hasHeight = value; } 120 void setHasHeight(bool value) { m_hasHeight = value; }
121 121
122 FloatRect filterPrimitiveSubregion() const { return m_filterPrimitiveSubregi on; } 122 FloatRect filterPrimitiveSubregion() const { return m_filterPrimitiveSubregi on; }
123 void setFilterPrimitiveSubregion(const FloatRect& filterPrimitiveSubregion) { m_filterPrimitiveSubregion = filterPrimitiveSubregion; } 123 void setFilterPrimitiveSubregion(const FloatRect& filterPrimitiveSubregion) { m_filterPrimitiveSubregion = filterPrimitiveSubregion; }
124 124
125 FloatRect effectBoundaries() const { return m_effectBoundaries; } 125 FloatRect effectBoundaries() const { return m_effectBoundaries; }
126 void setEffectBoundaries(const FloatRect& effectBoundaries) { m_effectBounda ries = effectBoundaries; } 126 void setEffectBoundaries(const FloatRect& effectBoundaries) { m_effectBounda ries = effectBoundaries; }
127 void applyEffectBoundaries(FloatRect&) const;
Stephen White 2015/11/19 14:54:34 I'm not a fan of non-const-refs as arguments, sinc
fs 2015/11/19 15:48:09 Done.
127 128
128 Filter* filter() { return m_filter; } 129 Filter* filter() { return m_filter; }
129 const Filter* filter() const { return m_filter; } 130 const Filter* filter() const { return m_filter; }
130 131
131 bool clipsToBounds() const { return m_clipsToBounds; } 132 bool clipsToBounds() const { return m_clipsToBounds; }
132 void setClipsToBounds(bool value) { m_clipsToBounds = value; } 133 void setClipsToBounds(bool value) { m_clipsToBounds = value; }
133 134
134 ColorSpace operatingColorSpace() const { return m_operatingColorSpace; } 135 ColorSpace operatingColorSpace() const { return m_operatingColorSpace; }
135 virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColo rSpace = colorSpace; } 136 virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColo rSpace = colorSpace; }
136 137
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 bool m_clipsToBounds; 189 bool m_clipsToBounds;
189 190
190 ColorSpace m_operatingColorSpace; 191 ColorSpace m_operatingColorSpace;
191 192
192 RefPtr<SkImageFilter> m_imageFilters[4]; 193 RefPtr<SkImageFilter> m_imageFilters[4];
193 }; 194 };
194 195
195 } // namespace blink 196 } // namespace blink
196 197
197 #endif // FilterEffect_h 198 #endif // FilterEffect_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698