Move application of filter effect boundaries to a helper

Move application of filter effect boundaries to a helper

Add FilterEffect::applyEffectBoundaries and use that to replace the
three chunks that does the same thing.
Drop a redundant null-check in FETile::createImageFilter.

Committed: https://crrev.com/0d49f0a0f8954673268e884e3fbe67eafff680f7
Cr-Commit-Position: refs/heads/master@{#360625}

[fs, 2015-11-19 13:04:53]

fs@opera.com changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-11-19 14:54:34]

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FETile.cpp (right):

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FETile.cpp:52:
inputEffect(0)->applyEffectBoundaries(srcRect);
Can inputEffect(0) not be null here?

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right):

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:127: void
applyEffectBoundaries(FloatRect&) const;
I'm not a fan of non-const-refs as arguments, since it's not clear from
the callsite that the argument is modified. Could you make this 
take a const ref and return the new FloatRect? This would also make it 
more in line with mapRect() and friends.

[fs, 2015-11-19 15:48:09]

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FETile.cpp (right):

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FETile.cpp:52:
inputEffect(0)->applyEffectBoundaries(srcRect);
On 2015/11/19 at 14:54:34, Stephen White wrote:
> Can inputEffect(0) not be null here?

Nope. (That should even hold generally - at least for FilterEffects built via
SVGFilterBuilder. In this specific case this was already assumed by all the
other methods.)

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right):

https://codereview.chromium.org/1463513002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:127: void
applyEffectBoundaries(FloatRect&) const;
On 2015/11/19 at 14:54:34, Stephen White wrote:
> I'm not a fan of non-const-refs as arguments, since it's not clear from
> the callsite that the argument is modified. Could you make this 
> take a const ref and return the new FloatRect? This would also make it 
> more in line with mapRect() and friends.

Done.

[Stephen White, 2015-11-19 15:51:32]

LGTM

[fs, 2015-11-19 16:54:39]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-11-19 16:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463513002/20001

[commit-bot: I haz the power, 2015-11-19 18:07:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 18:09:00]

Patchset 2 (id:??) landed as
https://crrev.com/0d49f0a0f8954673268e884e3fbe67eafff680f7
Cr-Commit-Position: refs/heads/master@{#360625}