Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: tests/GpuDrawPathTest.cpp

Issue 1463493002: Fix GpuDrawPathTest on ANGLE and enable it (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/GpuDrawPathTest.cpp
diff --git a/tests/GpuDrawPathTest.cpp b/tests/GpuDrawPathTest.cpp
index 3702a7cc3b03ee45e2c4673efa7b73b43155a2bc..75c55262688202607eb7e3f286eee3f84c9da25a 100644
--- a/tests/GpuDrawPathTest.cpp
+++ b/tests/GpuDrawPathTest.cpp
@@ -75,9 +75,6 @@ static void test_drawSameRectOvals(skiatest::Reporter*, SkCanvas* canvas) {
}
DEF_GPUTEST(GpuDrawPath, reporter, factory) {
- // https://bugs.chromium.org/p/skia/issues/detail?id=4581
- return;
-
for (int type = 0; type < GrContextFactory::kLastGLContextType; ++type) {
GrContextFactory::GLContextType glType = static_cast<GrContextFactory::GLContextType>(type);
@@ -93,6 +90,9 @@ DEF_GPUTEST(GpuDrawPath, reporter, factory) {
SkAutoTUnref<SkSurface> surface(
SkSurface::NewRenderTarget(grContext, SkSurface::kNo_Budgeted, info,
sampleCounts[i], nullptr));
+ if (!surface) {
+ continue;
+ }
test_drawPathEmpty(reporter, surface->getCanvas());
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698