Issue 1463493002: Fix GpuDrawPathTest on ANGLE and enable it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1463493002: Fix GpuDrawPathTest on ANGLE and enable it (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen

Modified:
5 years, 1 month ago

Reviewers:
bsalomon, f(malita)

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix GpuDrawPathTest on ANGLE and enable it Fix GpuDrawPathTest on ANGLE by avoiding a crash if MSAA surface creation fails. Enable the test. BUG=skia:4581 Committed: https://skia.googlesource.com/skia/+/c11a527cd06a0a6c2cef0d986ea8f5ef0989505a

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tests/GpuDrawPathTest.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

f(malita)

LGTM If this sticks, we can also move test_drawSameRectOvals back to GpuDrawPath and get rid ...

5 years, 1 month ago (2015-11-19 15:15:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463493002/1

5 years, 1 month ago (2015-11-19 17:24:22 UTC) #6

commit-bot: I haz the power

5 years, 1 month ago (2015-11-19 17:37:04 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c11a527cd06a0a6c2cef0d986ea8f5ef0989505a

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages