Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1463483002: [heap] Move slot recording of weak fields in native context to native context list retainer. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move slot recording of weak fields in native context to native context list retainer. BUG= Committed: https://crrev.com/45a52b624a820194497770ebce31750fa74c39ec Cr-Commit-Position: refs/heads/master@{#32109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/heap/objects-visiting.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
5 years, 1 month ago (2015-11-19 09:47:06 UTC) #2
ulan
lgtm
5 years, 1 month ago (2015-11-19 09:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463483002/1
5 years, 1 month ago (2015-11-19 10:39:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:52:40 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:53:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45a52b624a820194497770ebce31750fa74c39ec
Cr-Commit-Position: refs/heads/master@{#32109}

Powered by Google App Engine
This is Rietveld 408576698